Add sort option for breadcrumb symbol trees#61420
Merged
jrieken merged 2 commits intomicrosoft:masterfrom Oct 23, 2018
ryanclarke:master
Merged
Add sort option for breadcrumb symbol trees#61420jrieken merged 2 commits intomicrosoft:masterfrom ryanclarke:master
jrieken merged 2 commits intomicrosoft:masterfrom
ryanclarke:master
Conversation
'Position' shows symbols in file position order (default). 'Name' shows symbols in alphabetical order. 'Type' shows the symbols in symbol type order. The configuration setting is not watched anywhere since the breadcrumbs tree view is transient and would dissapear in changing the setting.
|
|
jrieken
reviewed
Oct 22, 2018
Member
jrieken
left a comment
jrieken
left a comment
There was a problem hiding this comment.
Look pretty good so far. Please update the setting name and we are good
outlineSort is now symbolSortOrder
Member
|
looking good. Thanks @ryanclarke 👏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
'Position' shows symbols in file position order (default).
'Name' shows symbols in alphabetical order.
'Type' shows the symbols in symbol type order.
The configuration setting is not watched anywhere since the
breadcrumbs tree view is transient and would disappear in
changing the setting.
Implements #56695
Effected by styling bug #61365