include priority in requestItem and add to request queue accordingly#60582
Conversation
|
@mjbvz |
mjbvz
left a comment
There was a problem hiding this comment.
Right general idea but needs some work:
-
I don't think we should introduce priority levels like low and high. Rather all requests should have the same priority (as they do today) with us specifically marking a few requests as low priority.
-
Make sure to mark the code lens reference's request as low priority since this was the original focus of #60213
-
Don't touch
executeWithoutWaitingForResponse. It's separate from this issue
|
Thanks for the review.
Does that mean that we will have to insert all other request in the
By marking, do you mean we'll have to get the request type within the Based on your review remarks, I believe that I'll have to remove the |
Let me know if that makes sense |
|
I hope I got your points.
Let me know if anything should be updated further. |
mjbvz
left a comment
There was a problem hiding this comment.
Approach for the queue looks good but again make sure to hook this up to mark the references lens requests as low priority.
extensions/typescript-language-features/src/typescriptServiceClient.ts
Outdated
Show resolved
Hide resolved
extensions/typescript-language-features/src/typescriptServiceClient.ts
Outdated
Show resolved
Hide resolved
I couldn't get to the point where the references codelens request is being made to add the flag. Could you please guide me a little on this one. (although I tried to trace) |
mjbvz
left a comment
There was a problem hiding this comment.
Queue changes look good. Please make sure to update the references calls of execute in referencesCodeLens too so that this logic is actually being used somewhere
|
Just saw your comment. Yeah I just realized that we don't directly call execute in this path anymore and instead use a command that invokes this indirectly: https://github.com/Microsoft/vscode/blob/4b8f928808f3fbf4745702d3b558e8ccbe2a726a/extensions/typescript-language-features/src/features/referencesCodeLens.ts#L21 This was a fairly recent change: dc47417 I'll merge this PR in as is and see what we want to do about the references requests |
Tries to fix #60213