Skip to content

Add setting to allow to disable Replace Preview#60153

Merged
roblourens merged 3 commits intomicrosoft:masterfrom
ToothlessGear:feature_allow_disabling_replace_preview_setting
Oct 9, 2018
Merged

Add setting to allow to disable Replace Preview#60153
roblourens merged 3 commits intomicrosoft:masterfrom
ToothlessGear:feature_allow_disabling_replace_preview_setting

Conversation

@ToothlessGear
Copy link
Contributor

@ToothlessGear ToothlessGear commented Oct 8, 2018

Introduces a new settings option "search.useReplacePreview" which
allows you to disable "Replace Preview" during a Search/Replace.

Closes #60027

@ToothlessGear
Add setting to allow to disable Replace Preview
a342380 
Introduces a new settings option "search.useReplacePreview" which
allows you to disable "Replace Preview" during a Search/Replace.

Closes #60027
roblourens
roblourens requested changes Oct 8, 2018
View reviewed changes
Copy link
Member

@roblourens roblourens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you check whether we need to check the setting here too? https://github.com/Microsoft/vscode/blob/master/src/vs/workbench/parts/search/browser/searchActions.ts#L581

@roblourens roblourens added this to the October 2018 milestone Oct 8, 2018
@ToothlessGear
Copy link
Contributor Author

ToothlessGear commented Oct 8, 2018

Hi,

regarding https://github.com/Microsoft/vscode/blob/master/src/vs/workbench/parts/search/browser/searchActions.ts#L581.
I checked this, but I am not sure how to trigger the alternative path in the condition. The condition seems to be always true and therefore never opens Replace Preview.

@roblourens
Copy link
Member

roblourens commented Oct 8, 2018

I see it when clicking the replace button in a file with a bunch of matches.

@ToothlessGear
Copy link
Contributor Author

ToothlessGear commented Oct 9, 2018

I think I got it now, thanks for taking the time to review.

roblourens
roblourens approved these changes Oct 9, 2018
View reviewed changes
Copy link
Member

@roblourens roblourens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@roblourens roblourens merged commit def5463 into microsoft:master Oct 9, 2018
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@roblourens roblourens roblourens approved these changes

Assignees

@roblourens roblourens

Labels

None yet

Projects

None yet

Milestone

October 2018

Development

Successfully merging this pull request may close these issues.

Allow disabling "Replace Preview"

2 participants

@ToothlessGear @roblourens