feat: enable mojave dark mode support#59742
Merged
bpasero merged 1 commit intomicrosoft:masterfrom Oct 1, 2018
Merged
Conversation
…uilt on the 10.14 SDK
Member
|
@MarshallOfSound thanks. you can use this build (Electron 3.0.x included) to try it out: https://az764295.vo.msecnd.net/exploration/1e9d10654dfff127230af65393f0d3cd285ed2e4/VSCode-darwin-exploration.zip |
This was referenced Oct 1, 2018
Contributor
Author
|
@bpasero Works perfectly 👍 |
|
When can we get this Mojave Dark Mode support for VS Code? |
|
@bpasero Is this expected out soon for VS Code? Dark Mode is so nice on the eyes |
Contributor
|
Is it fixed in insider builds? I still have the problem (even if macOS hasn't dark mode enabled, I see a gray line on top of VSCode). |
Member
Contributor
|
@bpasero unfortunately it doesn't fix the problem:
|
Member
|
@warpdesign those builds are old, you should get an update and then its fine |
bpasero
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Electron is not built on the 10.14 SDK so we need to set a special
Info.plistkey to tell macOS we support dark mode.Closes #59421
Closes #59283
Closes #54838 (maybe, the line looks a little different but I think it's how mojave dark mode windows look)
Blocked by: joaomoreno/gulp-atom-electron#51