Skip to content

Isidorn/debug start#59617

Merged
isidorn merged 4 commits intomasterfrom
isidorn/debugStart
Oct 1, 2018
Merged

Isidorn/debug start#59617
isidorn merged 4 commits intomasterfrom
isidorn/debugStart

Conversation

@isidorn
Copy link
Collaborator

@isidorn isidorn commented Sep 28, 2018

fixes #54214
fixes #58822

This PR restructures the debugService.startDebugging such that:

  • Compound configurations are no longer recursivly calling into startDebugging
  • Initialization state is being enterted on the very start
  • startDebugging now properly returns a boolean success. We can change this to an enum if in the future we need more fine grained result
  • ExtHostDebugService adopts to this newest change
  • some documentation update

@isidorn isidorn added this to the October 2018 milestone Sep 28, 2018
@isidorn isidorn self-assigned this Sep 28, 2018
@isidorn isidorn merged commit 15192ac into master Oct 1, 2018
@isidorn isidorn deleted the isidorn/debugStart branch October 1, 2018 09:32
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@isidorn isidorn

Labels

None yet

Projects

None yet

Milestone

October 2018

Development

Successfully merging this pull request may close these issues.

Restructuring DebugService.startDebugging and DebugService.createSession startDebugging method in vscode still return true even when the build fails

1 participant

@isidorn