Open Workspace button in .code-workspace files, fixes #59305#59586
Closed
jgbright wants to merge 1 commit intomicrosoft:masterfrom
Closed
Open Workspace button in .code-workspace files, fixes #59305#59586jgbright wants to merge 1 commit intomicrosoft:masterfrom
jgbright wants to merge 1 commit intomicrosoft:masterfrom
Conversation
Member
|
Sorry, I worked on this at the same time it seems, should have removed the "help wanted" label then. My change in 329a4af is a bit closer to the implementation we already had for keybindings and preferences, so I prefer it. |
Contributor
Author
|
@bpasero Thanks for the follow up. The original request was for a small code change, but I did wonder if it would be better to follow the “contribution” design. It’s interesting to see how you did it. |
Member
|
@jgbright I think both solutions work fine, but the contribution model takes it out of the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.