Merged
Conversation
added 5 commits
August 23, 2018 18:01
JacksonKearl
force-pushed
the
settings-tweaks
branch
from
9718fe0 to
c2d594a
Compare
added 4 commits
August 24, 2018 14:50
…conditions can be edited
unable to edit a when setting in some cases unable to edit a defualt setting to/from a nondefault one and probbaly some others.
Contributor
Author
|
This implements persisting the order of the rows of exclude controls while editing by sorting the keys. Potential downside to this is that it writes out the sorted value to the settings, which will show up in version control. This could be confusing, but if they're editing the excludes anyways it probably isn't that bad. |
Contributor
Author
|
Of the remaining two, I don't think I'll be able to paginate the list in the remaining <1 hour I'm here, and playing with the editor a bit I don't actually think a special "go to next control" tab is very critical, as we don't have that many links. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addressing some of the "More Issues" in #55791.
So far:
Closes #56928
Closes #57033
Closes #57167
Closes #57172