Enum descriptions in new settings editor via SelectBox widget#57050
Merged
JacksonKearl merged 3 commits intomicrosoft:masterfrom Aug 24, 2018
Merged
Conversation
JacksonKearl
commented
Aug 23, 2018
|
|
||
| if (options.actionHandler) { | ||
| options.actionHandler.disposeables.push(DOM.addStandardDisposableListener(element, 'click', event => { | ||
| options.actionHandler.disposeables.push(DOM.addStandardDisposableListener(element, options.eventToIntercept || 'click', event => { |
Contributor
Author
There was a problem hiding this comment.
This change is sloppy.
Contributor
Author
There was a problem hiding this comment.
It was needed because the widget disappears before a click can complete. Alternative ideas appreciated.
Member
There was a problem hiding this comment.
If this was just to support links then I think we can remove it.
roblourens
approved these changes
Aug 24, 2018
Member
roblourens
left a comment
roblourens
left a comment
There was a problem hiding this comment.
I think we want to avoid having links in enumDescriptions, one way or another - I can always fiddle with that later. LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #55796
Alternative implementation to #56511.
Main concern with this approach is the styling needed to separate the details from the list items. In this implementation I've added an additional color token that specifies the border colors for the dropdown and separating line, which defaults to the
editorWidgetBordercolor, and only applies if the existingsettingsDropdownBorderis the same as the list background color. Its a confusing process that is required because of the lightness of the dropdown, and still doesnt give great results, as theeditorWidgetBorderis typically used against darker backgrounds, and in as such appears washed out in some dark themes.Dark+:
Dracula:
Monokai:
Solarized Dark:
Light themes are better because these tend to define a dropdown border color which acts as a good fallback:
Solarized Light:
