Extract autosuggest editor to own class; bring into settings#55924
Extract autosuggest editor to own class; bring into settings#55924JacksonKearl merged 4 commits intomicrosoft:masterfrom
Conversation
bring into settings
|
This probably breaks some smoke tests. We'll see. |
|
|
||
| .autosuggest-input-container .suggest-widget { | ||
| width: 275px; | ||
| } |
| this.searchWidget = this._register(this.instantiationService.createInstance(AutosuggestEnabledInput, `${SettingsEditor2.ID}.searchbox`, searchContainer, { | ||
| triggerCharacters: ['@'], | ||
| provideResults: (query: string) => { | ||
| return ['@modified', '@tag:usesOnlineServices'].filter(tag => query.indexOf(tag) === -1).map(tag => tag + ' '); |
There was a problem hiding this comment.
Without actually trying this, does this mean that if I type @mod it will still return @tag:usesOnlineServices?
There was a problem hiding this comment.
The filtering is handled externally. This controls the base options. So if you have @modified in your query already, it wont suggest it again. If you type @, @tag:usesOnlineServices will appear, but if you go on to type m, it will go away.
roblourens
left a comment
roblourens
left a comment
There was a problem hiding this comment.
The settings side of this at least looks good to me
|
@ramya-rao-a do you have input on the location of these files? Right now I'm putting them under |
|
Should the new class be |
JacksonKearl
force-pushed
the
settings-autosuggest
branch
from
8c1d305 to
6f10ff7
Compare
|
@roblourens good point, made the change. |
|
Hey @ramya-rao-a could you take a look? |
3 participants
This closes #55804.