Merged
Conversation
mjbvz
reviewed
Jul 31, 2018
Collaborator
mjbvz
left a comment
mjbvz
left a comment
There was a problem hiding this comment.
Change looks good. Thanks for looking into this!
Let's hold of on merging this until next iteration though if that's ok with you. That way we get more users trying it out in insiders
Contributor
Author
|
Sure, makes sense |
Contributor
Author
|
@mjbvz this should be good to merge now |
Collaborator
|
@JacksonKearl Thanks. Please keep an eye on incoming issues for markdown folding (in insiders only of course) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #45118.
In some cases the region comments get parsed as nested children of other elements and are not registered as being proper folding regions. This seems to only occur with wacky formatting, so I'd vote to keep the simple implementation as is unless it comes up in more common cases.