Set diff editor border to match regular editor border. #53931
Merged
joaomoreno merged 2 commits intomicrosoft:masterfrom Jul 16, 2018
Merged
Set diff editor border to match regular editor border. #53931joaomoreno merged 2 commits intomicrosoft:masterfrom
joaomoreno merged 2 commits intomicrosoft:masterfrom
Conversation
…ith no shadow showing no diff between editors.
sa-adebayo
reviewed
Jul 12, 2018
| export const diffInsertedOutline = registerColor('diffEditor.insertedTextBorder', { dark: null, light: null, hc: '#33ff2eff' }, nls.localize('diffEditorInsertedOutline', 'Outline color for the text that got inserted.')); | ||
| export const diffRemovedOutline = registerColor('diffEditor.removedTextBorder', { dark: null, light: null, hc: '#FF008F' }, nls.localize('diffEditorRemovedOutline', 'Outline color for text that got removed.')); | ||
|
|
||
| export const diffBorder = registerColor('diffEditor.diffEditorBorder', { dark: '#444444', light: '#E7E7E7', hc: contrastBorder }, nls.localize('diffEditorBorder', 'Border color of separation between original and modified diff editors.')); |
There was a problem hiding this comment.
The description could be better written as 'Border color between the original and modified diff editors.'
What do you think?
Contributor
Author
There was a problem hiding this comment.
That's a much better description! Done.
|
You could adjust the PR description for those who want to know what was done at first glance. Does it look clearer, if not please adjust. |
itamark
changed the title
Member
|
Thanks, renamed it to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set diff editor border to match regular editor border.
Solves issue with no shadow showing no diff between editors.
Solves #53523