Keep item expanded after rename#44362
Merged
isidorn merged 2 commits intomicrosoft:masterfrom Feb 26, 2018
Merged
Conversation
Contributor
Author
|
@bpasero my commit is clear but it fails due to hygiene script. Am i missing some rule? |
Contributor
|
Maybe a whitespace after |
Contributor
Author
|
My local hygiene script doesnt throw any errors and the space after "if" doesnt appears anywhere in code, or in hygiene config. I will keep it as is until some reviewer check it and comment about it. |
Contributor
Author
|
Hygiene fix, thanks @usernamehw , i m blind apparently. 👅 |
Contributor
|
These build checks don't work ~70% of the time for me 😄 |
Collaborator
|
@ntovas great work, thanks a lot 🍻 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #44230
Checks if the item is expanded and expanding it again after the rename.