Renaming Close Unmodified to Close Unsaved#44269
Merged
bpasero merged 2 commits intomicrosoft:masterfrom Feb 26, 2018
Merged
Conversation
|
|
Member
|
@itamark note that we cannot change identifiers of actions/commands, because people might have associated keybindings already. |
Contributor
Author
|
@bpasero Oh, good to know. That makes sense. Should I change all instances of |
Contributor
Author
|
@bpasero okay put back the action identifiers. |
Contributor
Author
|
@bpasero kind of looks like the failures are not related to my commit. Is that possible? |
Member
|
Its fine, I merged it with a follow up change: 8015c58 Thanks 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#44033