#42557 fix - make open in command multiselect aware #43552
#42557 fix - make open in command multiselect aware #43552isidorn merged 4 commits intomicrosoft:masterfrom
Conversation
|
|
|
@sriram-dev thanks for your PR. This looks good for me. @Tyriar do you wish to review as well or you leave this up to me? |
| directoryMap.set(directoryToOpen, true); | ||
| if (configurationService.getValue<ITerminalConfiguration>().terminal.explorerKind === 'integrated') { | ||
| const instance = integratedTerminalService.createInstance({ cwd: directoryToOpen }, true); | ||
| if (instance) { |
There was a problem hiding this comment.
Instead of setting active and showing the panel for every instance, how about we set and show only once for the "primary" selection (I think that's a thing @isidorn?).
There was a problem hiding this comment.
Sure will check.
There was a problem hiding this comment.
Is there a primary selection? How do we identify it if so. Currently its being set for every instance on the order in which instances are selected. So we could choose to set active only for the last instance or first instance. Confirm the approach.
There was a problem hiding this comment.
@sriram-dev primary selection is the resource passed in the command. The getResourcesForCommand gets all the other selected elements (including the primary)
|
@isidorn Yes |
|
@isidorn Please review and confirm if the changes are good |
|
@sriram-dev thanks for your PR I have merged it in 🍻 |
|
Yay! Thanks! |
5 participants
No description provided.