Skip to content

Remove needless check for array in ContextKeyChangeEvent#42914

Merged
jrieken merged 1 commit intomicrosoft:masterfrom
Connormiha:optimize-context-key-change-event
Feb 26, 2018
Merged

Remove needless check for array in ContextKeyChangeEvent#42914
jrieken merged 1 commit intomicrosoft:masterfrom
Connormiha:optimize-context-key-change-event

Conversation

@Connormiha
Copy link
Contributor

Removed check isArray and use concat for both cases, because concat works correct with array and not array as argument.

['mike', 'bob'].concat('alex'); // ['mike', 'bob', 'alex']
['mike', 'bob'].concat(['alex', 'bill']); // ['mike', 'bob', 'alex', 'bill']

@jrieken jrieken added this to the February 2018 milestone Feb 26, 2018
@jrieken jrieken merged commit 43fbb43 into microsoft:master Feb 26, 2018
@jrieken
Copy link
Member

jrieken commented Feb 26, 2018

Thanks. Learnt something!

@github-actions github-actions bot locked and limited conversation to collaborators Mar 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants