Allow middle mouse click to open file entry in the background#42769
Merged
bpasero merged 5 commits intomicrosoft:masterfrom Feb 5, 2018
usernamehw:mmc_quick_open
Merged
Allow middle mouse click to open file entry in the background#42769bpasero merged 5 commits intomicrosoft:masterfrom usernamehw:mmc_quick_open
bpasero merged 5 commits intomicrosoft:masterfrom
usernamehw:mmc_quick_open
Conversation
bpasero
requested changes
Feb 2, 2018
| // Trigger open of element on selection | ||
| if (this.isVisible()) { | ||
| let mode = preferredMode || Mode.OPEN; | ||
| let mode = (event && event.payload && event.payload.originalEvent && event.payload.originalEvent.middleButton ? Mode.OPEN_IN_BACKGROUND : false) || preferredMode || Mode.OPEN; |
Member
There was a problem hiding this comment.
I would prefer if this was done at the place where the event happens (here) and then passed over as preferredMode
Member
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #42714