Support theming of active line number#42301
Support theming of active line number#42301rebornix merged 3 commits intomicrosoft:masterfrom usernamehw:theming_active_line_number
Conversation
|
@usernamehw I like the idea of using |
| export const editorWhitespaces = registerColor('editorWhitespace.foreground', { dark: '#e3e4e229', light: '#33333333', hc: '#e3e4e229' }, nls.localize('editorWhitespaces', 'Color of whitespace characters in the editor.')); | ||
| export const editorIndentGuides = registerColor('editorIndentGuide.background', { dark: editorWhitespaces, light: editorWhitespaces, hc: editorWhitespaces }, nls.localize('editorIndentGuides', 'Color of the editor indentation guides.')); | ||
| export const editorLineNumbers = registerColor('editorLineNumber.foreground', { dark: '#5A5A5A', light: '#2B91AF', hc: Color.white }, nls.localize('editorLineNumbers', 'Color of editor line numbers.')); | ||
| export const editorActiveLineNumber = registerColor('editorActiveLineNumber.foreground', { dark: null, light: null, hc: null }, nls.localize('editorActiveLineNumber', 'Color of editor active line number')); |
There was a problem hiding this comment.
I'm thinking if we should have this feature by default, by assigining proper foreground for default themes.
There was a problem hiding this comment.
Are you suggesting to assign colors for shipped with vscode themes: [monokai, red, ...] or default values for all themes? Assigning a default for all themes will look weird for a lot of themes: For instance, if I assign some gray color for all dark themes as default and a theme has a blue(or some other distant from gray) it would really stand out.
There was a problem hiding this comment.
I agree with @usernamehw to use 'null' as default here. That way we don't break anyone.
There was a problem hiding this comment.
I'm convinced that null is a good value.
|
Colors for default themes are set now... |
|
@usernamehw sorry for the back-and-forth on whether we should have active line number support in default themes, can we revert the last commit and keep default |
|
@rebornix, The default value is still |
|
@usernamehw thanks for your contribution again ;) Active line number works extremely well for dark themes or themes which are already using active line background, so I'd like to cherry-pick some of your second commit (those active line number colors), hope you don't mind. |
|
Sure, it was the whole point of adding them. |
3 participants
Fixes #21825