FIXED: issue window opened as modal/child, fixes #42024#42028
FIXED: issue window opened as modal/child, fixes #42024#42028RMacfarlane merged 3 commits intomicrosoft:masterfrom
Conversation
|
One thing to keep in mind is that the issue reporter can be opened without any other window being open. |
|
Didn't know that: how to reproduce this behavior? |
|
@nico-onmap the idea is that from the help menu you can "Report Issue" and it would open the reporter. |
|
Right, I was thinking about Windows where you cannot have a menu bar without a window. But on macOS (and Linux?) it can happen indeed. |
|
@nico-onmap yeah macOS only |
|
@bpasero This should handle macOS special case properly now. |
not a good idea to use that)
|
After all, using modal option wasn't such a good idea: in macOS, sheets are used when modal is specified, and they have no close button, so there was no way to close the issue reporter without sending a new report. I only left the |
|
@nico-onmap Thanks, this looks good |
I think the issue reporter window shouldn't be opened as
always on top. This PR opens it as modal instead.See #42024.