[fix-panel-auto-maximize] removes condition which contraints panelHeight#41800
Conversation
|
@isidorn I removed the condition which was creating the problem ( as below ). Why was it added in the first place? Anything I missed? |
|
@shobhitchittora thanks for the PR. The check was there if the panel got explictly maximized(using the action) that it shuold stay maximized. Though I prefer that we remove this, so your PR is fine. |
3e3c868 to
03277ab
Compare
|
@isidorn Thanks for pointing that out. Just curious! Shouldn't the unused var be flagged by eslint in the editor itself and not allow me to push? Instead It was showing up as (green underlined) - What are your views on this? PS: regarding the issue I also checked with triggering |
|
@shobhitchittora I get tslint errors the way I have vscode setup and that is how I found this. Not sure why you did not see it though Thanks for the PR 🍻 |

Closes: #41625
Checklist -