Add time variables for snippets#41653
Merged
jrieken merged 5 commits intomicrosoft:masterfrom Jan 17, 2018
usernamehw:time_variables_for_snippets
Merged
Add time variables for snippets#41653jrieken merged 5 commits intomicrosoft:masterfrom usernamehw:time_variables_for_snippets
jrieken merged 5 commits intomicrosoft:masterfrom
usernamehw:time_variables_for_snippets
Conversation
jrieken
requested changes
Jan 16, 2018
|
|
||
| resolve(variable: Variable): string { | ||
| const { name } = variable; | ||
| const zeroPad = (n: string): string => n.length < 2 ? `0${n}` : n; |
Member
There was a problem hiding this comment.
better use the existing util from base/common/strings#pad
Contributor
Author
There was a problem hiding this comment.
Didn't know about it
jrieken
added
feature-request
jrieken
approved these changes
Jan 16, 2018
Member
|
Would you might adding a test? At least for manifesting the names of the those variables? Maybe have your code so that the date to be used is an optional ctor-argument. Thanks already. |
Contributor
Author
|
Travis-CI build stuck > 10 hours. |
Member
|
lgtm. Thanks |
|
has this been released into a build yet? do I use it like |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #41631
@jrieken