Skip to content

Add copy command action to keybinding editor context menu#41567

Merged
sandy081 merged 2 commits intomicrosoft:masterfrom
Digized:master
Jan 17, 2018
Merged

Add copy command action to keybinding editor context menu#41567
sandy081 merged 2 commits intomicrosoft:masterfrom
Digized:master

Conversation

@Digized
Copy link
Contributor

@Digized Digized commented Jan 13, 2018

this is a solution for #41483.

Please let me know if I need to make any changes, this being my first open source pr

@msftclas
Copy link

msftclas commented Jan 13, 2018

CLA assistant check
All CLA requirements met.

@Digized Digized changed the title Add copy command action to keybinding editor context me Add copy command action to keybinding editor context menu Jan 13, 2018
@sandy081 sandy081 added the keybindings-editor Keybinding editor issues label Jan 15, 2018
@sandy081 sandy081 added this to the January 2018 milestone Jan 15, 2018
@sandy081
Copy link
Member

@Digized Thanks for the PR.

You would need to add the actions to our keybindings registry just like other actions. Refer here

@sandy081
Copy link
Member

@mccreeker Your request to add more copy commands is being considered and thanks to @Digized for the initiative.

The PR provides an action to copy the command in the keybindings editor. Let me know if it works for you.

Thanks.

@sandy081 sandy081 merged commit 524bf8b into microsoft:master Jan 17, 2018
@sandy081
Copy link
Member

@Digized LGTM. Merged.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

keybindings-editor Keybinding editor issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants