fix: add word boundray to check markdown italic#41466
Merged
mjbvz merged 2 commits intomicrosoft:masterfrom Jan 24, 2018
mikaoelitiana:fix-40787
Merged
fix: add word boundray to check markdown italic#41466mjbvz merged 2 commits intomicrosoft:masterfrom mikaoelitiana:fix-40787
mjbvz merged 2 commits intomicrosoft:masterfrom
mikaoelitiana:fix-40787
Conversation
mjbvz
reviewed
Jan 16, 2018
| <dict> | ||
| <key>begin</key> | ||
| <string>(?x) | ||
| (\*|_)(?=\S) # Open |
Collaborator
There was a problem hiding this comment.
Can you please update markdown.tmLanguage.base as well. We use that file to generate this one. You can run the generator using (cd extensions/markdown; npm run update-grammar)
There was a problem hiding this comment.
line 3371 must be changed from
<string>(?<=\S)(\1)((?!\1)|(?=\1\1))</string>
to
<string>(?<=\S)(\1)((?!\1)|(?=\1\1))\b</string>
Contributor
Author
There was a problem hiding this comment.
Thank you for review. I will fix that today
|
|
Collaborator
|
Thanks! This will be in the next insiders build and is on track for VS Code 1.20 |
Contributor
Author
|
Great news!!! Thank you
Mika ANDRIANARIJAONA
[email protected]
06 95 08 91 24
@mikaoelitiana
2018-01-24 17:41 GMT+01:00 Matt Bierner <[email protected]>:
… Thanks! This will be in the next insiders build and is on track for VS
Code 1.20
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#41466 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AApLa2iKziR_1I1Wb3B9pFKizlsPnsojks5tN11QgaJpZM4RapuY>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #40787