Set the minimum height of the xterm scrollbar thumb to 35px#41385
Merged
Tyriar merged 2 commits intomicrosoft:masterfrom Jan 14, 2018
YannickMeeus:adding-min-height-to-xterm-scrollbar-thumb
Merged
Set the minimum height of the xterm scrollbar thumb to 35px#41385Tyriar merged 2 commits intomicrosoft:masterfrom YannickMeeus:adding-min-height-to-xterm-scrollbar-thumb
Tyriar merged 2 commits intomicrosoft:masterfrom
YannickMeeus:adding-min-height-to-xterm-scrollbar-thumb
Conversation
Member
|
Nice, that was easy 😄 @YannickMeeus we should match the min height of the editor's scrollbar, it looks like it's set to 20px there:
|
Contributor
Author
|
That makes perfect sense, and silly of me not to check that 😃 I'll get that change in right away. |
…be consistent with the editor defaults
Member
|
Awesome, thanks for looking into this 😃 |
Contributor
Author
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #35116.
Changes are minimal, testing performed was manual. I basically eye-balled a couple of minimum heights and 35px seems like a decent height.