Skip to content

Clarified documentation for Position functions#41317

Merged
jrieken merged 2 commits intomicrosoft:masterfrom
mathieubruguier:misleading-documentation-for-position-functions
Jan 11, 2018
Merged

Clarified documentation for Position functions#41317
jrieken merged 2 commits intomicrosoft:masterfrom
mathieubruguier:misleading-documentation-for-position-functions

Conversation

@mathieubruguier
Copy link
Contributor

Fixes #41221.

Simple text changes for the documentation since it used to be confusing.


/**
* Check if `other` equals this position.
* Check if this is position is equal to `other`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extra 'is'

@jrieken jrieken added this to the January 2018 milestone Jan 11, 2018
@jrieken jrieken added the api label Jan 11, 2018
@mathieubruguier
Copy link
Contributor Author

My bad, not sure how I missed that. I fixed it.

@jrieken
Copy link
Member

jrieken commented Jan 11, 2018

Thanks

@jrieken jrieken merged commit 08a8b1e into microsoft:master Jan 11, 2018
@mathieubruguier mathieubruguier deleted the misleading-documentation-for-position-functions branch January 25, 2018 22:12
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Misleading documentation for Position functions

2 participants