workbench: Adds actions for moveEditorToFirstGroup, moveEditorToSecondGroup, moveEditorToThirdGroup#40635
Conversation
|
@bpasero Are there any tests to extend upon? |
There was a problem hiding this comment.
@shobhitchittora keybinding KeyMod.CtrlCmd | KeyMod.Alt | KeyCode.KEY_1 is already taken by "Toggle Editor Layout" and cannot be used again
There was a problem hiding this comment.
Correct me if I'm wrong -
- The primary key binding scheme is applied to Windows and Linux builds. Mac has it's own primary binding object specified.
KeyMod.CtrlCmd | KeyMod.Alt | KeyCode.KEY_1is MAC-primary for "Toggle Editor Layout", while it's WIN/LINUX-primary for "MoveEditorToFirstGroupAction".- Any other suggestions?
There was a problem hiding this comment.
@shobhitchittora you are right, sorry I did not see the mac specific keybinding
There was a problem hiding this comment.
Thanks for looking into it 👍🏻.
There was a problem hiding this comment.
@shobhitchittora remove the trailing Action from the action ids (e.g. workbench.action.moveEditorToFirstGroup)
There was a problem hiding this comment.
@shobhitchittora all these actions are very similar in their implementation. Can we have a base class (abstract) that all classes extend from and in the base class we simply have a method to ask for the position?
shobhitchittora
force-pushed
the
move-editor-specific-group
branch
from
2f6209a to
bfabb2a
Compare
|
@bpasero Any idea why Travis is failing?
|
|
LGTM thanks 👍 |
|
Hi, Why couldn't I find these shortcuts in my Thank you |
|
The VSCode version im using
|
|
@hardianlawi they got removed. Read this and this. |
3 participants
Adds the following actions for workbench tabs -
(For Mac Only - TODO: Need to confirm the same in Win & UNIX)
^ ⌘ 1^ ⌘ 2^ ⌘ 3Fixes: #40525