Skip to content

Add theme-specific color customizations. Fix #36860#40460

Merged
aeschli merged 8 commits intomicrosoft:masterfrom
usernamehw:theme_specific
Dec 21, 2017
Merged

Add theme-specific color customizations. Fix #36860#40460
aeschli merged 8 commits intomicrosoft:masterfrom
usernamehw:theme_specific

Conversation

@usernamehw
Copy link
Contributor

@usernamehw usernamehw commented Dec 18, 2017 •
edited
Loading

My attempt at implementing theme-scoped color customizations #36860 .

update_theme
intellisense

  • IntelliSense in settings
  • Colors update on settings change
  • Colors update on theme change
  • Priority scoped => customized => theme

Settings example:

"workbench.colorCustomizations": {
    "[Monokai Dimmed]": {
        "activityBar.background": "#66F",
    },
    "activityBar.background": "#ddd",
    "[Monokai]": {
        "activityBar.background": "#F66"
    }
},
"editor.tokenColorCustomizations": {
    "[Monokai Dimmed]": {
        "comments": "#66F",
    },
    "comments": "#ddd",
    "[Monokai]": {
        "textMateRules": [{
            "scope": "comment",
            "settings": {
                "foreground": "#F66"
            },   
        }]
    },
},

cc @aeschli

@aeschli
Copy link
Contributor

aeschli commented Dec 19, 2017

@usernamehw Looks good!
Only suggestion is to improve the way how the schema is constructed. What do you think?

@aeschli aeschli added this to the December 2017/January 2018 milestone Dec 19, 2017
@usernamehw
Copy link
Contributor Author

usernamehw commented Dec 19, 2017 •
edited
Loading

It now register configuration with properties as empty object so it doesn't have to write them twice.

In addition, it uses shallow copy instead of deep.

@usernamehw
Copy link
Contributor Author

usernamehw commented Dec 20, 2017

@aeschli I made some changes...

@aeschli aeschli merged commit befd40a into microsoft:master Dec 21, 2017
@aeschli
Copy link
Contributor

aeschli commented Dec 21, 2017

Thanks a lot @usernamehw , great PR!

@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@aeschli aeschli

Labels

None yet

Projects

None yet

Milestone

January 2018

Development

Successfully merging this pull request may close these issues.

2 participants

@usernamehw @aeschli