feat(workbench/window): add setting to switch TouchBar on macOS#40400
Closed
viztor wants to merge 1 commit intomicrosoft:masterfrom
Closed
feat(workbench/window): add setting to switch TouchBar on macOS#40400viztor wants to merge 1 commit intomicrosoft:masterfrom
viztor wants to merge 1 commit intomicrosoft:masterfrom
Conversation
|
|
bpasero
requested changes
Dec 18, 2017
| 'default': true | ||
| } | ||
| }, | ||
| 'workbench.touchBar.enabled': { |
Member
There was a problem hiding this comment.
@viztor the setting should only be enabled on macOS, not all platforms. I also suggest to move it into the existing keyboard category:
E.g. call it keyboard.touchBar.enabled
| import { IIntegrityService } from 'vs/platform/integrity/common/integrity'; | ||
| import { AccessibilitySupport, isRootUser, isWindows, isMacintosh } from 'vs/base/common/platform'; | ||
| import product from 'vs/platform/node/product'; | ||
| import { ConfigurationService } from 'vs/platform/configuration/node/configurationService'; |
Member
|
Marking as duplicate of #40692 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.