Update Ruby indent pattern#40292
Merged
aeschli merged 2 commits intomicrosoft:masterfrom Dec 15, 2017
Merged
Conversation
Contributor
|
Thanks @TeeSeal ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I didn't bother to make an issue for this one but here are the problems:
While I can see why it doesn't auto-indent when theres a
{or;character on the line, this behavior is not something we want when those characters are inside a string or regular expression.Some keywords are detected inside comments, leading to an auto-indent, which is also not something we want.
Current behavior:
Updated behavior:
This PR makes auto-indent ignore characters/keywords inside strings, regular expressions and comments.
@rebornix
P.S. please take a look at my PR for the vscode-ruby extension since it overwrites this default behavior and is not yet patched.