adding suggestion to search for extension for files are of unknown mime type#40269
adding suggestion to search for extension for files are of unknown mime type#40269ramya-rao-a merged 4 commits intomicrosoft:masterfrom sbatten:users/stbatt/fbextrec
Conversation
|
guessMimeType sometimes returns MIME_UNKNOWN for known extensions. There appears to be a race between this logic and the registration of known mime types. |
ramya-rao-a
left a comment
ramya-rao-a
left a comment
There was a problem hiding this comment.
Nice work, left a few tiny comments. Take a look.
There was a problem hiding this comment.
I believe this is a remnant of a copy paste :)
There was a problem hiding this comment.
I added the new ignore list to the store because I can imagine if a user has a specific file type that never will definitely not have an extension, they would be pretty annoyed by the new message if it repeated. As for the this.ignoreExtensionRecommendations(), I left this as well since this triggers the prompt for ignoring all recommendation notifications and will also work to disable this new message. Let me know what you think.
There was a problem hiding this comment.
I got the part about the new ignore list earlier. That's good.
Am not sure about re-purposing this.ignoreExtensionRecommendations() for the file extension search.
Some users may not want any recommendations, but may be ok with the file search or vice versa
There was a problem hiding this comment.
You can skip the 3 Promise.as(null) here. They won't end up serving any purpose
There was a problem hiding this comment.
Can you add the telemetry events to track what the user does here just like in the other choiceService?
sbatten
left a comment
sbatten
left a comment
There was a problem hiding this comment.
this change makes sense and worked for me as expected after adding more important tips
|
@sbatten There are few more things we need to hash out before merging this to master. Thanks for all the work though, this is nice feature to have |
2 participants
When user loads a file of unknown mime type in the editor, suggest searching for an extension in the marketplace supporting that file extension.