Expose border style for debug toolbar. Fixes #39324#39976
Merged
isidorn merged 2 commits intomicrosoft:masterfrom Dec 13, 2017
usernamehw:patch-2
Merged
Expose border style for debug toolbar. Fixes #39324#39976isidorn merged 2 commits intomicrosoft:masterfrom usernamehw:patch-2
isidorn merged 2 commits intomicrosoft:masterfrom
usernamehw:patch-2
Conversation
Collaborator
|
@usernamehw great PR, thanks a lot! Currently you add the border transparent even if the theme is not specifying the color, this means that the widget will be larger by 2px in the default case. Can we handle this same as with Once you adress this I will merge the PR in. |
Collaborator
|
@usernamehw looks good to me, thanks a lot for the pr! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#39324