Skip to content

handle multi-line messages in multi-line patterns#39935

Merged
dbaeumer merged 2 commits intomicrosoft:masterfrom
doudou:handle_multiline_messages
Dec 13, 2017
Merged

handle multi-line messages in multi-line patterns#39935
dbaeumer merged 2 commits intomicrosoft:masterfrom
doudou:handle_multiline_messages

Conversation

@doudou
Copy link
Contributor

@doudou doudou commented Dec 8, 2017

This modifies the handling of multiline message reporters, where more than one pattern have a message field.

For instance

{
  "regexp": "^\\(\\d+\\) .+\\(([^\\)]+)\\): (failed in .* phase)$",
  "file": 1,
  "message": 2
},
{
  "regexp": "^    (.*)",
  "message": 1,
  "loop": true
}

The existing behaviour was to use the first matching message. This PR changes this by appending to an existing message instead (retaining newlines).

One obvious question is whether the new behaviour should be made optional or not.

@sandy081 sandy081 requested a review from dbaeumer December 12, 2017 09:23
@sandy081 sandy081 assigned dbaeumer and unassigned sandy081 Dec 12, 2017
@dbaeumer
Copy link
Member

dbaeumer commented Dec 12, 2017

@doudou nice work. I would only request one thing. If running under Windows I would use '\r\n' in case this every escapes into a file.

@doudou
Copy link
Contributor Author

doudou commented Dec 13, 2017

Updated. FYI, I couldn't test on Windows (don't have a windows machine).

@dbaeumer
Copy link
Member

I can do the testing under Windows. Thanks again for providing this.

@dbaeumer dbaeumer added this to the December 2017/January 2018 milestone Dec 13, 2017
@dbaeumer dbaeumer merged commit 29e57ec into microsoft:master Dec 13, 2017
@doudou doudou deleted the handle_multiline_messages branch December 13, 2017 20:13
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants