handle multi-line messages in multi-line patterns#39935
Merged
dbaeumer merged 2 commits intomicrosoft:masterfrom Dec 13, 2017
Merged
handle multi-line messages in multi-line patterns#39935dbaeumer merged 2 commits intomicrosoft:masterfrom
dbaeumer merged 2 commits intomicrosoft:masterfrom
Conversation
Member
|
@doudou nice work. I would only request one thing. If running under Windows I would use '\r\n' in case this every escapes into a file. |
Contributor
Author
|
Updated. FYI, I couldn't test on Windows (don't have a windows machine). |
Member
|
I can do the testing under Windows. Thanks again for providing this. |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This modifies the handling of multiline message reporters, where more than one pattern have a message field.
For instance
The existing behaviour was to use the first matching message. This PR changes this by appending to an existing message instead (retaining newlines).
One obvious question is whether the new behaviour should be made optional or not.