LGTM

@ethernetcable unless I am mistaken, the same old limit applies for people typing in CJK languages, no? So your fix does not seem to account for that.

@bpasero you are right, I have changed the limit if the user's display language is not CJK.

Can anyone tell me why this would fail hygiene? I can't work it out.

Thanks 👍

This doesn't look right to me. The limit is calculated in a per-character basis, so it won't show the correct limit for mixed characters or emoji (also double-counted)

@bpasero this won't work for the reasons I highlighted in this comment. Twitter will update their library likely in mid-Dec to give a correct solution.

@chrbala @kumarharsh I would still argue this is an improvement to the way it was before. We never accounted for mixed characters or emojis in our previous solution. We can still tweak this further to resolve those issues, but for the majority of people the limit of 280 will be correct.

Yeah, makes sense. Good enough is better than nothing 👍