fix debug console to handle more than one graphics mode in a single escape sequence#38981
Merged
isidorn merged 2 commits intomicrosoft:masterfrom Nov 27, 2017
Merged
fix debug console to handle more than one graphics mode in a single escape sequence#38981isidorn merged 2 commits intomicrosoft:masterfrom
isidorn merged 2 commits intomicrosoft:masterfrom
Conversation
…e in one escape sequence
Collaborator
Collaborator
|
@dyc3 I checked and this indeed fixes #6845 - great! |
Contributor
Author
|
@isidorn Ah, I didn't see that before. I'll see what I can figure out. |
Contributor
Author
|
Unless there is something I'm missing, there is a practical limit to the number of graphic modes specified at one time: bold, underscore, blink, reverse video, concealed, foreground color. and background color. So limiting |
Collaborator
|
@dyc3 looks good, thanks a lot. Merging it in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


According to ascii-table.com, the spec allows for more than one graphics mode to be specified at a time.