Fixes markdown link syntax highlighting bug#38328
Merged
mjbvz merged 1 commit intomicrosoft:masterfrom Nov 14, 2017
shivammittal99:markdown-bug
Merged
Fixes markdown link syntax highlighting bug#38328mjbvz merged 1 commit intomicrosoft:masterfrom shivammittal99:markdown-bug
mjbvz merged 1 commit intomicrosoft:masterfrom
shivammittal99:markdown-bug
Conversation
Issue: #38049 Signed-off-by: Shivam Mittal <[email protected]>
|
|
Collaborator
|
Thanks! Fix will be in the next insiders build |
Collaborator
|
Sorry, this change things and had to be reverted. The problem is that when the regexp capture group was deleted, we also need to shift all the capture indices after it down. I will take a quick look into fixing this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Issue: #38049
Removed the optional space in regexp for the link markdown