Skip to content

Make v8-profiler, css-parser URI http-proxy friendly#38181

Merged
ramya-rao-a merged 1 commit intomicrosoft:masterfrom
nehaljwani:patch-1
Nov 13, 2017
Merged

Make v8-profiler, css-parser URI http-proxy friendly#38181
ramya-rao-a merged 1 commit intomicrosoft:masterfrom
nehaljwani:patch-1

Conversation

@nehaljwani
Copy link
Contributor

No description provided.

@msftclas
Copy link

msftclas commented Nov 13, 2017

CLA assistant check
All CLA requirements met.

@jrieken
Copy link
Member

jrieken commented Nov 13, 2017

Can you elaborate a little on this?

@nehaljwani
Copy link
Contributor Author

On a machine behind corporate proxy:

(vscode) [nwani@machine vscode ] (master)$ node --version
v8.9.1

(vscode) [nwani@machine vscode ] (master)$ npm --version
5.5.1

(vscode) [nwani@machine vscode ] (master)$ env | grep -i proxy
https_proxy=http://proxy.my-corporate.com:3128

(vscode) [nwani@machine vscode ] (master)$ ./scripts/npm.sh install --arch=x64

> [email protected] preinstall /spare/scratch/1510575918/vscode
> node build/npm/preinstall.js

npm WARN read-shrinkwrap This version of npm is compatible with lockfileVersion@1, but npm-shrinkwrap.json was generated for lockfileVersion@0. I'll try to do my best with it!
npm ERR! Error while executing:
npm ERR! /usr/bin/git ls-remote -h -t git://github.com/jrieken/v8-profiler.git
npm ERR! 
npm ERR! fatal: unable to connect to github.com:
npm ERR! github.com[0: 192.30.253.113]: errno=Connection refused
npm ERR! github.com[1: 192.30.253.112]: errno=Connection refused
npm ERR! 
npm ERR! 
npm ERR! exited with error code: 128

^C^C^C

Now apply this patch and npm succeeds

(vscode) [nwani@machine vscode ] (master)$ sed -i 's,git://,git+https://,' npm-shrinkwrap.json 

(vscode) [nwani@machine vscode ] (master *)$ git diff
diff --git a/npm-shrinkwrap.json b/npm-shrinkwrap.json
index 203fa2d..d0014ac 100644
--- a/npm-shrinkwrap.json
+++ b/npm-shrinkwrap.json
@@ -544,7 +544,7 @@
     "v8-profiler": {
       "version": "5.6.5",
       "from": "jrieken/v8-profiler#vscode",
-      "resolved": "git://github.com/jrieken/v8-profiler.git#5e4a336693e1d5b079c7aecd286a1abcfbc10421"
+      "resolved": "git+https://github.com/jrieken/v8-profiler.git#5e4a336693e1d5b079c7aecd286a1abcfbc10421"
     },
     "vscode-debugprotocol": {
       "version": "1.24.0",

(vscode) [nwani@machine vscode ] (master *)$ ./scripts/npm.sh install --arch=x64

> [email protected] preinstall /spare/scratch/1510575918/vscode
> node build/npm/preinstall.js

npm WARN read-shrinkwrap This version of npm is compatible with lockfileVersion@1, but npm-shrinkwrap.json was generated for lockfileVersion@0. I'll try to do my best with it!
npm WARN deprecated [email protected]: Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue
npm WARN deprecated [email protected]: Use uuid module instead
npm WARN deprecated [email protected]: Jade has been renamed to pug, please install the latest version of pug instead of jade
npm WARN deprecated [email protected]: to-iso-string has been deprecated, use @segment/to-iso-string instead.
npm WARN deprecated [email protected]: Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue
npm WARN deprecated [email protected]: Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue
npm WARN deprecated [email protected]: Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue

> [email protected] preinstall /spare/scratch/1510575918/vscode/node_modules/typechecker
> node ./cyclic.js


> [email protected] install /spare/scratch/1510575918/vscode/node_modules/oniguruma
> node-gyp rebuild

@nehaljwani
Copy link
Contributor Author

This is similar to the change: 87c476a

@nehaljwani nehaljwani changed the title Make v8-profiler URI http-proxy friendly Make v8-profiler, css-parser URI http-proxy friendly Nov 13, 2017
@ramya-rao-a ramya-rao-a added this to the November 2017 milestone Nov 13, 2017
@ramya-rao-a
Copy link
Contributor

Thanks @nehaljwani

@ramya-rao-a ramya-rao-a merged commit ecb2beb into microsoft:master Nov 13, 2017
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants