Add logging snippets for Javascript & typescript#37889
Merged
mjbvz merged 1 commit intomicrosoft:masterfrom Nov 10, 2017
abinavseelan:feature/logging-snippets-js-ts
Merged
Add logging snippets for Javascript & typescript#37889mjbvz merged 1 commit intomicrosoft:masterfrom abinavseelan:feature/logging-snippets-js-ts
mjbvz merged 1 commit intomicrosoft:masterfrom
abinavseelan:feature/logging-snippets-js-ts
Conversation
|
|
Contributor
|
@egamma @mattbierner How do we usually balance built-in snippets vs extension provided? |
Collaborator
|
@auchenberg My idea for what should be a built-in snippet:
This one fits the first two well. As for the third, these snippets are not a huge improvement over suggestions IMO but I do think they are a nice quality of life addition |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add logging snippets for Javascript & Typescript
This PR addresses #37839 😄
Context
One nifty set of snippets that I do miss from my time with Atom are the
log,warnanderrorsnippets for Javascript.log=>console.log()warn=>console.warn()error=>console.error()Changes
log,warnanderrorsnippets toextensions/javascript/snippets/javascript.jsonwarnanderrorsnippets toextensions/typescript/snippets/typescript.jsonAfter Changes