Conversation
|
|
| const visibility = this.configurationService.getValue<string>(ToggleTabsVisibilityAction.tabsVisibleKey); | ||
| const newVisibilityValue = !visibility; | ||
|
|
||
| return this.configurationService.updateValue(ToggleTabsVisibilityAction.tabsVisibleKey, newVisibilityValue, ConfigurationTarget.USER); |
There was a problem hiding this comment.
@sandy081 how is the state of things here, shouldn't we stay away from setting an explicit Configuration.TARGET and rather let the service decide where to update the value based on where it is defined?
@maxfurman the issue here is that this setting could be defined on a workspace level and then writing it back to user level would not cause any visual change.
There was a problem hiding this comment.
@bpasero Yes, Do not use the target, if the action is intended to change the current effective value. Current state is that all existing actions are still using the target (debt item). Make sure new ones do not cause the debt.
There was a problem hiding this comment.
@maxfurman can you make that change to not set the target?
There was a problem hiding this comment.
No problem. Simply removing the third argument to updateValue will do the trick, correct?
|
Thanks 👍 |
|
Thanks @maxfurman ! |
5 participants
Fixes #30314
Toggle the visibility of editor tabs, with keyboard shortcut ctrl-cmd-W