Skip to content

Fix 37385 by introducing addition configuration setting#37704

Merged
isidorn merged 4 commits intomicrosoft:masterfrom
hun1ahpu:fix37385
Nov 8, 2017
Merged

Fix 37385 by introducing addition configuration setting#37704
isidorn merged 4 commits intomicrosoft:masterfrom
hun1ahpu:fix37385

Conversation

@hun1ahpu
Copy link
Contributor

@hun1ahpu hun1ahpu commented Nov 6, 2017

Fixing the issue #37385
Adding configuration parameter that allows the user to control if s(he) wants to open debug viewlet on every debug session, on the first only or never.

@isidorn
Copy link
Collaborator

isidorn commented Nov 7, 2017

@hun1ahpu thanks for this PR, I like the work. Here's my feedback, once you adress it we can merge this in:

  • I would prefer if this is only a vscode configuration setting, and not a configuration in the launch.json. I know that internalConsoleOptions is present in both configurations and in launch but that is for historic reasons and I am not a fan of that
  • I would prefer that the configuration name is debug.openDebug
    That way the name is complementary with debug.openExplorerOnEnd. And the values I would keep as to what you already have.

Thanks a lot

@isidorn isidorn added this to the November 2017 milestone Nov 7, 2017
@hun1ahpu
Copy link
Contributor Author

hun1ahpu commented Nov 7, 2017

@isidorn please take a look on the new iteration.
I renamed the setting to openDebugOnStart (similar to openExplorerOnEnd)
I think I've removed it from launch.json setting but I'm not sure. Could you check please?
Thanks

@isidorn
Copy link
Collaborator

isidorn commented Nov 7, 2017

@hun1ahpu please rename it to exactly openDebug I have discussed the name in great length with a collegue. This is our choice to not have duplication between name and value.
Yes it looks like you have removed it from the launch.json

@hun1ahpu
Copy link
Contributor Author

hun1ahpu commented Nov 7, 2017

@isidorn Done :)

@isidorn
Copy link
Collaborator

isidorn commented Nov 8, 2017

@hun1ahpu thanks a lot for your PR 🍻. Merging in

@isidorn isidorn merged commit bf0949b into microsoft:master Nov 8, 2017
@isidorn
Copy link
Collaborator

isidorn commented Nov 8, 2017

I have cleaned this up a bit via bc04f0c

@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants