Fixing integrated terminal font-size overflow#37636
Merged
Tyriar merged 1 commit intomicrosoft:masterfrom Nov 6, 2017
shobhitchittora:int-term-max-font-size
Merged
Fixing integrated terminal font-size overflow#37636Tyriar merged 1 commit intomicrosoft:masterfrom shobhitchittora:int-term-max-font-size
Tyriar merged 1 commit intomicrosoft:masterfrom
shobhitchittora:int-term-max-font-size
Conversation
Tyriar
approved these changes
Nov 6, 2017
Member
Tyriar
left a comment
Tyriar
left a comment
There was a problem hiding this comment.
Looks great! Thanks for the contribution 👍
shobhitchittora
added a commit
to shobhitchittora/vscode
that referenced
this pull request
Dec 14, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This puts a maximum limit to allowed font-size for integrated terminal in VSCode.
Checklist
npm run watch)"terminal.integrated.fontSize" : 1500in OSS Dev VSCode.Fixes #37455