Fix different error message in source and package.nls for npm package#37096
Merged
egamma merged 2 commits intomicrosoft:masterfrom Oct 31, 2017
Merged
Fix different error message in source and package.nls for npm package#37096egamma merged 2 commits intomicrosoft:masterfrom
egamma merged 2 commits intomicrosoft:masterfrom
Conversation
Error message was different in main.ts.
Member
|
@qcz Thanks for the fix! |
egamma
pushed a commit
that referenced
this pull request
Oct 31, 2017
#37096) * Fix package.nls.json for npm Error message was different in main.ts. * Fix language string key in npm/src/main.ts
Contributor
Author
Member
|
@qcz sorry, I forgot to assing a milestone to the PR, this is why we didn't find it. I will add it. |
Contributor
Author
|
@egamma: No problem! Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.