Merged
Conversation
joaomoreno
requested changes
Oct 27, 2017
Contributor
Author
|
@joaomoreno I think you may have misread this PR. Currently we just catch and throw away the error for fetch. This PR makes it so we don't throw it away. |
Member
|
Oh! |
Member
|
@keegancsmith You keep doing great work! Thanks man! 🍻 |
Contributor
Author
|
np! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The only place that calls
fetchwill handle the error correctly. So this should fix a bug were we don't disable autofetch when fetch fails due to auth issues.https://github.com/Microsoft/vscode/blob/3f4bb73cb98e6b4dcd5da6ddff74024ce71bd493/extensions/git/src/autofetch.ts#L62-L68