Skip to content

#3422 Add Region folding for bat#36911

Merged
aeschli merged 2 commits intomicrosoft:masterfrom
mvanderlee:master
Oct 26, 2017
Merged

#3422 Add Region folding for bat#36911
aeschli merged 2 commits intomicrosoft:masterfrom
mvanderlee:master

Conversation

@mvanderlee
Copy link
Contributor

@mvanderlee mvanderlee commented Oct 25, 2017 •
edited
Loading

#3422
Add ::#region, ::#endregion and REM #region, REM #endregion folding markers for bat

@KillyMXI
Copy link
Contributor

KillyMXI commented Oct 25, 2017

"^\\s*(::|REM)\\s*#region"
This could match for invalid sequence REM#region.

Possible alternatives:
"^\\s*(::|REM\\s?)\\s*#region"
"^\\s*(::\\s*|REM\\s+)#region"

@aeschli aeschli merged commit ef38f54 into microsoft:master Oct 26, 2017
@aeschli
Copy link
Contributor

aeschli commented Oct 26, 2017

Thanks @MichielVanderlee !
@KillyMXI Thanks for the suggestions. I applied your second proposal.

@aeschli aeschli added this to the October 2017 milestone Oct 26, 2017
@aeschli aeschli added languages-basic Basic language support issues feature-request Request for new features or functionality labels Oct 26, 2017
aeschli added a commit that referenced this pull request Oct 26, 2017
@aeschli
[bat] region marker improvement (for #36911)
022687c
@aeschli aeschli added the verification-needed Verification of issue is requested label Nov 1, 2017
@kthy kthy mentioned this pull request Dec 12, 2019
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@aeschli aeschli

Labels

feature-request Request for new features or functionality languages-basic Basic language support issues verification-needed Verification of issue is requested

Projects

None yet

Milestone

October 2017

Development

Successfully merging this pull request may close these issues.

3 participants

@mvanderlee @KillyMXI @aeschli