Skip to content

Call shellscript files just "Shell Script"#36889

Closed
dancek wants to merge 1 commit intomicrosoft:masterfrom
dancek:patch-1
Closed

Call shellscript files just "Shell Script"#36889
dancek wants to merge 1 commit intomicrosoft:masterfrom
dancek:patch-1

Conversation

@dancek
Copy link

@dancek dancek commented Oct 25, 2017

Currently VSCode displays filetype "Shell Script (Bash)" for all shell script files, including ones that are quite obviously not Bash or even Bash-compatible. Change the UI text to just "Shell Script" to be more accurate.

Here's what the footer looks like when editing .zshrc:
Image of footer when editing .zshrc. Includes text "Shell Script (Bash)"

Currently VSCode displays filetype "Shell Script (Bash)" for all shell script files, including ones that are quite obviously not Bash or even Bash-compatible. Change the UI text to just "Shell Script" to be more accurate.
@aeschli
Copy link
Contributor

aeschli commented Oct 27, 2017

@dancek Thanks! Yes, makes sense to shorten the label.

@aeschli aeschli added this to the October 2017 milestone Oct 27, 2017
@aeschli aeschli added the languages-basic Basic language support issues label Oct 27, 2017
@aeschli aeschli modified the milestones: October 2017, November 2017 Nov 3, 2017
@aeschli
Copy link
Contributor

aeschli commented Nov 3, 2017

Sorry, I thought I had pushed this. Will do in next release.

@dancek
Copy link
Author

dancek commented Nov 14, 2017

@aeschli is this a good time to remind you to merge this PR?

@aeschli
Copy link
Contributor

aeschli commented Nov 14, 2017

Yes, sure. I made the change in the package.json, that's what we use. The label in the tmLanguage.json file is not used in the UI.

@aeschli aeschli closed this in e1691a6 Nov 14, 2017
@github-actions github-actions bot locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

languages-basic Basic language support issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants