update keytar to 4.0.5#36849
Merged
chrmarti merged 1 commit intomicrosoft:masterfrom Oct 30, 2017
SteveDesmond-ca:patch-1
Merged
update keytar to 4.0.5#36849chrmarti merged 1 commit intomicrosoft:masterfrom SteveDesmond-ca:patch-1
chrmarti merged 1 commit intomicrosoft:masterfrom
SteveDesmond-ca:patch-1
Conversation
Collaborator
|
Update to the shrinkwrap file is missing, I'll add that. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
atom/node-keytar#80 makes cross-compilation for ARM possible, which was just tagged/released to npm in 4.0.5.
VSCode cross-compilation has been failing since keytar was introduced in 1.15.