Skip to content

Enable click and open mailto links in Markdown preview#36795

Merged
mjbvz merged 2 commits intomicrosoft:masterfrom
misoguy:fix#36601
Oct 25, 2017
Merged

Enable click and open mailto links in Markdown preview#36795
mjbvz merged 2 commits intomicrosoft:masterfrom
misoguy:fix#36601

Conversation

@misoguy
Copy link
Contributor

@misoguy misoguy commented Oct 24, 2017

Fixes #36601

@mjbvz mjbvz self-assigned this Oct 24, 2017
@mjbvz
Copy link
Collaborator

mjbvz commented Oct 24, 2017

Change looks good to me. Thanks for looking into this. Can you just please quickly resolve the merge conflict

@misoguy
Copy link
Contributor Author

misoguy commented Oct 25, 2017

@mjbvz I have resolved the merge conflict.
However, as I was doing so I found a bug(?) in the code which is causing the merge conflict.
newTab is returning null here and causing the editor not to open a new window when a link is clicked.
I think it'll be better for me to make a new pull request regarding this bug.

@mjbvz mjbvz added this to the October 2017 milestone Oct 25, 2017
@mjbvz mjbvz merged commit ca8bb6a into microsoft:master Oct 25, 2017
@mjbvz
Copy link
Collaborator

mjbvz commented Oct 25, 2017

Thanks! This should be in the next insiders build and in VSCode 1.18

@github-actions github-actions bot locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unable to click and open mailto links in Markdown preview

2 participants