Only restore expansion state when there are items.#36539
Only restore expansion state when there are items.#36539isidorn merged 1 commit intomicrosoft:masterfrom guw:gunnar/debugger
Conversation
|
@guw thanks for your pr. I have looked into it and here is some feedback:
Thanks again |
|
@isidorn Thanks for the feedback. I think there is an issue with the global variable. I'll revisit the logic. Re: formatting - Is there a trick? I do get a warning from the pre-commit hook. However, I was expecting VS Code to format on save. Also the format action seems to screw up the whole file. |
|
@guw yes please revisit the logic. In the latest I see that you are still using the global variable. |
|
@guw ok, makes sense.
|
|
@isidorn Do you have any suggestions on formatting? Whenever I try to format the document using VS Code it makes a ton of changes. |
|
@guw I will format. Can you please ansewer my questions from above. |
When a debugger needs more time while stepping, the tree will go empty first (while running) and then come back with data (when stopped again). This modifies the change for #16031 to allow the tree to properly restore state in case a debugger needs more time providing content. The expanded state is saved in a global variable. A check ensures that an intermittent empty tree does not override the global variable. Future refreshes of an empty tree will then restore the expanded state of variables.
|
@isidorn patch rebased, simplified and formatted.
|
|
@guw looks good to me, thanks a lot for your contribution 🍻 |
This modifies the change for #16031 to prevent the tree from collapsing
in case a debugger needs more time providing content.