Skip to content

Git submodules support.#36313

Merged
joaomoreno merged 4 commits intomicrosoft:masterfrom
petkahl:git-submodules
Dec 14, 2017
Merged

Git submodules support.#36313
joaomoreno merged 4 commits intomicrosoft:masterfrom
petkahl:git-submodules

Conversation

@petkahl
Copy link

@petkahl petkahl commented Oct 16, 2017

Basic support for #7829.

Automatically add submodules of added git repository when adding the repository.

When a repository is shown in the Index or Working tree resource groups, clicking on them does nothing. It would be better if either an informational message was shown, or the focus was shifted to that submodule in the Git view, but I'm not completely sure how to do the first, and the second doesn't seem possible at the moment.

@joaomoreno joaomoreno added the git GIT issues label Oct 16, 2017
@joaomoreno joaomoreno added this to the Backlog milestone Oct 16, 2017
@YanDevDe
Copy link

YanDevDe commented Oct 16, 2017

+1 I'm missing this features!

@petkahl
Copy link
Author

petkahl commented Nov 3, 2017

@joaomoreno , I don't want to push or get in the way of the team's workflow, but is there anything I could do to help this along?

@petkahl petkahl mentioned this pull request Nov 13, 2017
Closed
@joaomoreno joaomoreno modified the milestones: Backlog, December 2017/January 2018 Dec 13, 2017
@joaomoreno
Copy link
Member

joaomoreno commented Dec 13, 2017

@petkahl There were a few issues with this PR:

  • Big no no with using sync FS calls, I changed it to async
  • Parsing git submodule status seems flaky, so I changed it to manually parsing the .gitmodules file
  • There was no use for the submodule status, so I removed it
  • A lot of integration was missing (stage, unstage, revert, open, etc.)

Nevertheless, big thank you for pushing this forward! I have merged your changes into joao/submodules and I'm fixing up the issues as well as filling the blanks there. This PR will be closed as soon as that branch is merged to master.

@petkahl
Copy link
Author

petkahl commented Dec 13, 2017

I was thinking the submodule status would be useful for adding the capability to initialize the submodule from the UI, but I never got around to doing it, so for now removing it out is the right choice.
After this hits master, I may go work on some enhancements like that. For now I'm content to look at the changes you've made to understand them and hopefully make my next PR more straightforward to integrate.
Thanks!

@joaomoreno joaomoreno merged commit 124b9a4 into microsoft:master Dec 14, 2017
@github-actions github-actions bot locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@joaomoreno joaomoreno

Labels

git GIT issues

Projects

None yet

Milestone

January 2018

Development

Successfully merging this pull request may close these issues.

3 participants

@petkahl @YanDevDe @joaomoreno