Skip to content

Show preview tag on extention page if extension is in preview#36261

Merged
sandy081 merged 1 commit intomicrosoft:masterfrom
golf1052:master
Nov 14, 2017
Merged

Show preview tag on extention page if extension is in preview#36261
sandy081 merged 1 commit intomicrosoft:masterfrom
golf1052:master

Conversation

@golf1052
Copy link
Member

This fixes #13276

@sandy081
Copy link
Member

@golf1052 Thanks for the PR. I am not aware of preview extensions. Guess this is market place feature. Do you have an example of such an extension and how it is show in the market place?

@golf1052
Copy link
Member Author

@golf1052 golf1052 changed the title Show preview tag on extention page if extension is in in preview Show preview tag on extention page if extension is in preview Oct 16, 2017
@sandy081
Copy link
Member

@golf1052 My bad, Did not notice the issue. Will take a look. Thanks.

@sandy081 sandy081 self-requested a review October 16, 2017 16:50
@sandy081 sandy081 added the extensions Issues concerning extensions label Oct 16, 2017
@sandy081 sandy081 added this to the October 2017 milestone Oct 16, 2017
@golf1052
Copy link
Member Author

golf1052 commented Nov 1, 2017

Wanted to ping on the status of this, anything that I need to do?

@sandy081 sandy081 modified the milestones: October 2017, November 2017 Nov 2, 2017
@sandy081
Copy link
Member

sandy081 commented Nov 2, 2017

@golf1052 Will be taken care in November.

@golf1052
Copy link
Member Author

Hoping this will be merged in this month, thanks.

@sandy081 sandy081 merged commit 1351744 into microsoft:master Nov 14, 2017
@sandy081
Copy link
Member

LGTM

@golf1052
Copy link
Member Author

Great, thanks!

@github-actions github-actions bot locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

extensions Issues concerning extensions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Extensions don't appear as preview in product

3 participants