Correct the EBNF for snippets#36067
Merged
jrieken merged 1 commit intomicrosoft:masterfrom Oct 11, 2017
maokelong:master
Merged
Correct the EBNF for snippets#36067jrieken merged 1 commit intomicrosoft:masterfrom maokelong:master
jrieken merged 1 commit intomicrosoft:masterfrom
maokelong:master
Conversation
I reviewed the parse's code and think that `${sn:-else}` and `${sn:else}` may have the same function and should share the same status，which means that the pattern should be something like `'${' int ':-' else '}' | '${' int ':' else '}'` or not '${' int ':-' else '}' '${' int ':' else '}'.
Member
|
Thanks |
Member
|
@gregvanl Can you also please the doc-page with this change. Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I reviewed the parse's code and think that
${sn:-else}and${sn:else}may have the same function and should share the same status，which means that the pattern should be something like'${' int ':-' else '}' | '${' int ':' else '}'or not'${' int ':-' else '}' '${' int ':' else '}'.