Remove kludge that adds history item when new input is set on an editor#35682
Merged
bpasero merged 1 commit intomicrosoft:masterfrom Oct 10, 2017
beyang:master
Merged
Remove kludge that adds history item when new input is set on an editor#35682bpasero merged 1 commit intomicrosoft:masterfrom beyang:master
bpasero merged 1 commit intomicrosoft:masterfrom
beyang:master
Conversation
Member
|
Yeah looks like it because now we merge history locations more aggressively, I also think it can be removed. Thanks for noticing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is not related to any issue, but I noticed this code that seemed kludge-y and perhaps no longer necessary. The code was originally added to fix #11727, but when I remove it, the behavior remains correct. The history item this adds appears now to be redundant, and could cause issues down the line, even though it doesn't appear to cause any user-visible issues now. This is also the only place that
HistoryService.addis invoked outside ofHistoryServiceitself.